On Tue 2025-01-28 09:59:08, Christophe Leroy wrote: > > > Le 28/01/2025 à 09:45, Markus Elfring a écrit : > > > So ask yourself whether such a change is really worth it. > > Some change combinations can occasionally become more worthwhile, > > can't they? > > Sure that change would be perfect as part of a series which modifies > bootconfig_params(), but as a standalone change I can't see the benefit. I agree here: 1. Cosmetic changes just complicate merging branches with really useful changes. They are complicate backporting fixes to stable kernels. 2. Cosmetic changes are material for bikeshedding. Some people might prefer the original code because it is better readable for them... 3. The authors of cosmetic changes will not learn much by this. Also it will also not help much to gain any reputation. Best Regards, Petr
