> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Sent: Monday, January 13, 2025 2:16 PM
> To: Xu, Even <even.xu@xxxxxxxxx>
> Cc: Sun, Xinpeng <xinpeng.sun@xxxxxxxxx>; Jiri Kosina <jikos@xxxxxxxxxx>;
> Benjamin Tissoires <bentiss@xxxxxxxxxx>; Mark Pearson <mpearson-
> lenovo@xxxxxxxxx>; Srinivas Pandruvada
> <srinivas.pandruvada@xxxxxxxxxxxxxxx>; linux-input@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH next] HID: intel-thc-hid: intel-thc: Fix error code in
> thc_i2c_subip_init()
>
> Return -ENOMEM if the allocation fails. Don't return success.
>
> Fixes: 4228966def88 ("HID: intel-thc-hid: intel-thc: Add THC I2C config
> interfaces")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c b/drivers/hid/intel-
> thc-hid/intel-thc/intel-thc-dev.c
> index 92a1dbe9a928..4fc78b5a04b5 100644
> --- a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
> +++ b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
> @@ -1519,7 +1519,7 @@ int thc_i2c_subip_init(struct thc_device *dev, const
> u32 target_address,
>
> dev->i2c_subip_regs = devm_kzalloc(dev->dev, sizeof(i2c_subip_regs),
> GFP_KERNEL);
> if (!dev->i2c_subip_regs)
> - return PTR_ERR(dev->i2c_subip_regs);
> + return -ENOMEM;
>
Looks reasonable.
Thanks Dan!
Best Regards,
Even Xu
> return 0;
> }
> --
> 2.45.2
