On Wed, 08 Jan 2025 12:28:46 +0300, Dan Carpenter wrote: > My static checker rule complains about this code. The concern is that > if "sample_space" is negative then the "sample_space >= runtime->channels" > condition will not work as intended because it will be type promoted to a > high unsigned int value. > > strm->fifo_sample_size is SSI_FIFO_DEPTH (32). The SSIFSR_TDC_MASK is > 0x3f. Without any further context it does seem like a reasonable warning > and it can't hurt to add a check for negatives. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: renesas: rz-ssi: Add a check for negative sample_space commit: 82a0a3e6f8c02b3236b55e784a083fa4ee07c321 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark