Re: [PATCH] eth: fbnic: Avoid garbage value in fbnic_mac_get_sensor_asic()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 24 Dec 2024 10:27:29 +0800 Su Hui wrote:
> 'fw_cmpl' is uninitialized which makes 'sensor' and '*val' to be stored
> garbage value. Initialize 'fw_cmpl' with 'fdb->cmpl_data' to fix this
> problem.

Argh, this function should send a FW command to read the sensors, 
it does nothing today :/ Looks like an upstreaming fail..

If you'd like to fix this please just remove the body of the function
entirely and return -EOPNOTSUPP. We'll have to follow up in net-next
to fill in the gaps in sensor reading.
-- 
pw-bot: cr




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux