On Mon, Dec 02, 2024 at 04:05:01PM +0100, Benoît Sevens wrote: > Hi Dan, > > On Mon, 2 Dec 2024 at 13:57, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > > > The usb_get_descriptor() function does DMA so we're not allowed > > to use a stack buffer for that. Doing DMA to the stack is not portable > > all architectures. Move the "new_device_descriptor" from being stored > > on the stack and allocate it with kmalloc() instead. > > > > Thanks for fixing this. It looks good to me. > > Note that the commit that is being fixed is already queued for > backporting, so I don't know how this usually goes then. > It's fine. The stable scripts look for fixes to stable patches. But I also CC'd stable because your commit is CC'd for stable. Even CC'ing stable shouldn't be necessary here, maybe there is a rebase or something so the Fixes tag gets broken or maybe something else goes wrong. CC'ing stable is just an extra way to be careful. regards, dan carpenter