On 11/30/24 11:07, Dan Carpenter wrote:
> The devm_ioremap() function doesn't return error pointers, it returns
> NULL. Update the error checking to match.
>
> Fixes: 5d4d263e1c6b ("mailbox: Introduce support for T-head TH1520 Mailbox driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/mailbox/mailbox-th1520.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/mailbox-th1520.c b/drivers/mailbox/mailbox-th1520.c
> index 4e84640ac3b8..e16e7c85ee3c 100644
> --- a/drivers/mailbox/mailbox-th1520.c
> +++ b/drivers/mailbox/mailbox-th1520.c
> @@ -387,8 +387,10 @@ static void __iomem *th1520_map_mmio(struct platform_device *pdev,
>
> mapped = devm_ioremap(&pdev->dev, res->start + offset,
> resource_size(res) - offset);
> - if (IS_ERR(mapped))
> + if (!mapped) {
> dev_err(&pdev->dev, "Failed to map resource: %s\n", res_name);
> + return ERR_PTR(-ENOMEM);
> + }
>
> return mapped;
> }
Looks good, thanks !
Reviewed-by: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx>
