On Tue, Nov 12, 2024 at 07:32:24AM -0600, Serge E. Hallyn wrote: > On Tue, Nov 12, 2024 at 12:45:32PM +0000, Colin Ian King wrote: > > In the case where rc is equal to EOPNOTSUPP it is being reassigned a > > new value of zero that is never read. The following continue statement > > loops back to the next iteration of the lsm_for_each_hook loop and > > rc is being re-assigned a new value from the call to getselfattr. > > The assignment is redundant and can be removed. > > > > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> > > Reviewed-by: Serge Hallyn <serge@xxxxxxxxxx> > > (long as it doesn't go to stable :) > There is a tag for fixes which would break stable. Cc: <stable+noautosel@xxxxxxxxxx> # reason goes here, and must be present But this isn't a fix and it wouldn't break stable so probably that's not appropriate. regards, dan carpenter