Dan Carpenter wrote on Thu, Nov 07, 2024 at 12:45:33AM +0300: > On Wed, Nov 06, 2024 at 03:22:09PM +0000, Colin Ian King wrote: > > The assignments and return checks on ret are redundant. Clean up > > the code by just returning the return value from the call to > > v9fs_init_inode_cache. > [...] > > Better to delete the whole function and call v9fs_init_inode_cache() > directly. Makes sense, and if we go there delete v9fs_cache_unregister as well so the init/destroy pair properly; that also is a single function call. Thanks! -- Dominique Martinet | Asmadeus