On Thu, Oct 31, 2024 at 10:07:42AM +0100, Johan Hovold wrote: > On Thu, Oct 31, 2024 at 09:59:10AM +0300, Dan Carpenter wrote: > > The dev_dbg() call dereferences "urb" but it was already freed on the > > previous line. Move the debug output earlier in the function. > > Thanks for catching this, but please use a temporary variable for the > struct device pointer instead of changing the flow. > Why? The output is the same either way and this way is cleaner code. > Also make sure to include the driver name in the patch summary prefix > (i.e. "USB: serial: io_edgeport: ..."): Sure. regards, dan carpenter
