Hello Andrew!
On 24/10/14 02:22PM, Andrew Mbugua wrote:
> ---
It looks like your change is missing a change description. This usually
contains a short explaination on why the change in the patch makes sense
(i.e. here why the cast can be dropped).
Your patch is also missing the Developers Certificate of origin, i.e.
the "Signed-off-by: ..." line which checkpatch.pl also complains about:
$ ./scripts/checkpatch.pl --git HEAD
WARNING: Missing commit description - Add an appropriate one
ERROR: Missing Signed-off-by: line(s)
All of this is covered by the [submitting patches docs][1], so before
sending another revision of your change maybe go through this.
Cheers,
Chris
[1]: https://docs.kernel.org/process/submitting-patches.html
> drivers/net/xen-netback/netback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index 5836995d6774..35801828c78b 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1294,7 +1294,7 @@ static void xenvif_zerocopy_callback(struct sk_buff *skb,
> spin_lock_irqsave(&queue->callback_lock, flags);
> do {
> u16 pending_idx = ubuf->desc;
> - ubuf = (struct ubuf_info_msgzc *) ubuf->ctx;
> + ubuf = ubuf->ctx;
> BUG_ON(queue->dealloc_prod - queue->dealloc_cons >=
> MAX_PENDING_REQS);
> index = pending_index(queue->dealloc_prod);
> --
> 2.43.0
Attachment:
signature.asc
Description: PGP signature
