>>> rzg2l_irqc_common_init calls of_find_device_by_node, but the >>> corresponding put_device call is missing. >>> >>> Make sure we call put_device when failing. >>> >>> "make coccicheck" will complain about a missing put_device before >>> successfully returning from rzg2l_irqc_common_init, however, that's >>> a false positive. >>> >>> Fixes: 3fed09559cd8 ("irqchip: Add RZ/G2L IA55 Interrupt Controller driver") >> >> Might the application of scope-based resource management become more >> interesting accordingly? > > No, as explained in the comments: > >>> + /* >>> + * coccicheck complains about a missing put_device call before returning, but it's a false >>> + * positive. We still need &pdev->dev after successfully returning from this function. >>> + */ Please reconsider the applicability of mentioned programming interfaces once more (as an evolving software design alternative for goto chains). https://elixir.bootlin.com/linux/v6.12-rc2/source/include/linux/device.h#L1239 Regards, Markus