From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 23 Sep 2024 21:56:35 +0200
An of_node_put(np) call was immediately used after a pointer check
for a of_find_device_by_node() call in this function implementation.
Thus call such a function only once instead directly before the check.
This issue was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
drivers/phy/tegra/xusb.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index cfdb54b6070a..1a912ed52416 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -1345,12 +1345,9 @@ struct tegra_xusb_padctl *tegra_xusb_padctl_get(struct device *dev)
* only ever be one per SoC that would be a little overkill.
*/
pdev = of_find_device_by_node(np);
- if (!pdev) {
- of_node_put(np);
- return ERR_PTR(-ENODEV);
- }
-
of_node_put(np);
+ if (!pdev)
+ return ERR_PTR(-ENODEV);
padctl = platform_get_drvdata(pdev);
if (!padctl) {
--
2.46.1
