On Sun, Sep 22, 2024 at 03:32:44PM +0200, Christophe JAILLET wrote:
> Le 16/03/2024 à 17:31, Christophe JAILLET a écrit :
> > If of_platform_populate() fails, we must shutdown the FPGA, as already done
> > in the remove function.
> >
> > Fixes: 5b143d2a6ede ("bus: add driver for the Technologic Systems NBUS")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> > ---
> > Compile tested only.
> >
> > This patch is speculative and based on the output of one of my scripts that
> > tries to spot calls in .remove function that are not also in the error
> > handling path of the probe. I'm not familiar with the pwm_ API.
> >
> > I don't think that the locking in the remove function is needed here.
> >
> > Review with care.
> > ---
>
> I sent this patch a few months ago, but it never got any feed-back.
The patch looks right. I don't know how the ts_nbus works, but I'd hope
that at the moment ts_nbus_remove() is called, there are no more devices
on that bus that rely on the PWM being on. In that case the locking in
ts_nbus_remove() could be dropped, too.
Best regards
Uwe
Attachment:
signature.asc
Description: PGP signature
