Re: [PATCH] qlcnic: Use common error handling code in four functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 19, 2024 at 09:50:13PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 19 Sep 2024 21:30:45 +0200
> 
> Add jump targets so that a bit of exception handling can be better reused
> at the end of four function implementations.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

Hi Markus,

This is an old driver, that doesn't appear to have been under active
development for quite some time. Unless there is a way to exercise these
changes I don't think that clean-ups of this nature are worth the risk of
regressions they might introduce.

If we can see bugs in error paths, let's fix them.
Else, let's leave them be.

-- 
pw-bot: rejected




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux