Hi Dan,
thanks for fixing this!
On Fri, 2024-09-13 at 17:35 +0300, Dan Carpenter wrote:
> This was intended to be an IS_ERR() check, not a NULL check. The
> ep93xx_dma_of_probe() function doesn't return NULL pointers.
>
> Fixes: 4e8ad5ed845b ("dmaengine: cirrus: Convert to DT for Cirrus EP93xx")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>
> ---
> drivers/dma/ep93xx_dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index d084bd123c1c..ca86b2b5a913 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -1504,7 +1504,7 @@ static int ep93xx_dma_probe(struct platform_device *pdev)
> int ret;
>
> edma = ep93xx_dma_of_probe(pdev);
> - if (!edma)
> + if (IS_ERR(edma))
> return PTR_ERR(edma);
>
> dma_dev = &edma->dma_dev;
--
Alexander Sverdlin.
