On Thu, Aug 29, 2024 at 10:23:04PM GMT, Dan Carpenter wrote: > If the __qcuefi pointer is not set, then in the original code, we would > hold onto the lock. That means that if we tried to set it later, then > it would cause a deadlock. Drop the lock on the error path. That's > what all the callers are expecting. > > Fixes: 759e7a2b62eb ("firmware: Add support for Qualcomm UEFI Secure Application") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > drivers/firmware/qcom/qcom_qseecom_uefisecapp.c | 4 ++++ > 1 file changed, 4 insertions(+) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry