From: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx> Date: Tue, 27 Aug 2024 08:58:33 +0200 > On 8/26/24 19:14, Christophe JAILLET wrote: >> Le 26/08/2024 à 11:15, Przemek Kitszel a écrit : >>> On 8/23/24 11:10, Dan Carpenter wrote: >>>> On Fri, Aug 23, 2024 at 08:23:29AM +0200, Christophe JAILLET wrote: > >>>> It would be even nicer to move the ma_list allocation outside the loop: >>>> >>>> buf_size = struct_size(ma_list, mac_addr_list, >>>> IDPF_NUM_FILTERS_PER_MSG); >>>> ma_list = kmalloc(buf_size, GFP_ATOMIC); [...] >> So, I'm not sure to understand what you propose, or the code in >> idpf_add_del_mac_filters() and co. >> >>> >>> CCing author; CCing Olek to ask if there are already some refactors that >>> would conflict with this. I'm not aware of any MAC filter code refactors. >> >> I'll way a few days for these feedbacks and send a v2. > > Would be good to have simple memory cleanup first, and later (if at all) > to untangle our locks a bit. Thanks, Olek
