> -----Original Message----- > From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Sent: Thursday, August 15, 2024 12:25 PM > To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@xxxxxxxxxx> > Cc: Will Deacon <will@xxxxxxxxxx>; Robin Murphy > <robin.murphy@xxxxxxx>; Joerg Roedel <joro@xxxxxxxxxx>; Jason > Gunthorpe <jgg@xxxxxxxx>; Nicolin Chen <nicolinc@xxxxxxxxxx>; Michael > Shavit <mshavit@xxxxxxxxxx>; Mostafa Saleh <smostafa@xxxxxxxxxx>; Lu > Baolu <baolu.lu@xxxxxxxxxxxxxxx>; Kevin Tian <kevin.tian@xxxxxxxxx>; linux- > arm-kernel@xxxxxxxxxxxxxxxxxxx; iommu@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: [PATCH] iommu/arm-smmu-v3: Fix a NULL vs IS_ERR() check > > The arm_smmu_domain_alloc() function returns error pointers on error. It > doesn't return NULL. Update the error checking to match. > > Fixes: 52acd7d8a413 ("iommu/arm-smmu-v3: Add support for > domain_alloc_user fn") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Reviewed-by: Shameer Kolothum <shameerali.kolothum.thodi@xxxxxxxxxx> Thanks, Shameer