Re: [PATCH] reboot: add missing break to switch statement for LINUX_REBOOT_CMD_HALT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please don't drop the lists from the CC.

To be honest, I wouldn't bother with this patch but lots of people send lots of
patches that I probably wouldn't send and I send patches that they wouldn't
send.

If you want to resend it that's fine, but the commit message should say
something like, "The break statement isn't required for after a do_exit() call,
because it is a __noreturn function.  However, other do_exit() paths in this
switch() statement have a break statement so it looks weird.  Let's make this
consistent.  This change has no effect on runtime."

regards,
dan carpenter





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux