Hello Christophe, On Sat, Aug 10, 2024 at 11:39:04PM +0200, Christophe JAILLET wrote: > 'struct config_item_type' is not modified in this driver. > > This structure is only used with config_group_init_type_name() which takes > a const struct config_item_type* as a 3rd argument. > > This also makes things consistent with 'netconsole_target_type' witch is > already const. > > Constifying this structure moves some data to a read-only section, so > increase overall security, especially when the structure holds some > function pointers. > > On a x86_64, with allmodconfig: > Before: > ====== > text data bss dec hex filename > 33007 3952 1312 38271 957f drivers/net/netconsole.o > > After: > ===== > text data bss dec hex filename > 33071 3888 1312 38271 957f drivers/net/netconsole.o > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> Reviewed-by: Breno Leitao <leitao@xxxxxxxxxx> > Compile tested-only. I've tested it using a selftime I am creating, and it is all good. Thanks for the patch! --breno
