[AMD Official Use Only - AMD Internal Distribution Only]
Hi Dan,
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Sent: Friday, July 19, 2024 4:09 AM
> To: Yuan, Perry <Perry.Yuan@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Shenoy, Gautham Ranjal
> <gautham.shenoy@xxxxxxx>; Limonciello, Mario
> <Mario.Limonciello@xxxxxxx>; Yuan, Perry <Perry.Yuan@xxxxxxx>; Rafael
> J. Wysocki <rafael@xxxxxxxxxx>; Viresh Kumar <viresh.kumar@xxxxxxxxxx>;
> linux-pm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kernel-
> janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH] cpufreq: amd-pstate: Fix uninitialized variable in
> amd_pstate_cpu_boost_update()
>
> Smatch complains that "ret" could be uninitialized:
>
> drivers/cpufreq/amd-pstate.c:734 amd_pstate_cpu_boost_update()
> error: uninitialized symbol 'ret'.
>
> This seems like it probably is a real issue. Initialize "ret" to zero to be safe.
>
> Fixes: c8c68c38b56f ("cpufreq: amd-pstate: initialize core precision boost
> state")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/cpufreq/amd-pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 68c616b572f2..358bd88cd0c5 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -692,7 +692,7 @@ static int amd_pstate_cpu_boost_update(struct
> cpufreq_policy *policy, bool on)
> struct amd_cpudata *cpudata = policy->driver_data;
> struct cppc_perf_ctrls perf_ctrls;
> u32 highest_perf, nominal_perf, nominal_freq, max_freq;
> - int ret;
> + int ret = 0;
>
> highest_perf = READ_ONCE(cpudata->highest_perf);
> nominal_perf = READ_ONCE(cpudata->nominal_perf);
> --
> 2.43.0
Thanks for the fix.
LGTM
Reviewed-by: Perry Yuan <perry.yuan@xxxxxxx>
