On 7/15/2024 9:35 AM, Alex Williamson wrote:
> On Mon, 15 Jul 2024 09:17:41 -0700
> Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote:
>
>> On 7/12/2024 3:36 PM, Alex Williamson wrote:>>>> MODULE_LICENSE("GPL v2");
>>>>>> MODULE_INFO(supported, "Test driver that simulate serial port over PCI");
>>>>>> +MODULE_DESCRIPTION("Test driver that simulate serial port over PCI");
>>>
>>> Seems the preceding MODULE_INFO needs to be removed here. At best the
>>> added MODULE_DESCRIPTION is redundant, but "supported" is not a
>>> standard tag, so it's not clear what the purpose of that tag was meant
>>> to be anyway. Thanks,
>>>
>>> Alex
>>
>> My preference would be to just add the missing MODULE_DESCRIPTION() with this
>> patch since that fixes the existing warning. Removing an existing macro
>> invocation is out of scope for what I'm trying to accomplish.
>
> This adds a MODULE_DESCRIPTION that's redundant to the current
> MODULE_INFO, therefore I'd argue that it's not out of scope to replace
> the MODULE_INFO with a MODULE_DESCRIPTION to achieve your goal. Thanks,
>
> Alex
>
ok, let me post a v2
/jeff
