Re: [PATCH] spmi: add missing MODULE_DESCRIPTION() macros

Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> · Thu, 11 Jul 2024 11:09:23 -0700

On 6/26/24 09:15, Jeff Johnson wrote:
On 6/9/2024 5:40 PM, Jeff Johnson wrote:
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/hisi-spmi-controller.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/spmi-pmic-arb.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
---
  drivers/spmi/hisi-spmi-controller.c | 1 +
  drivers/spmi/spmi-pmic-arb.c        | 1 +
  2 files changed, 2 insertions(+)

diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c
index fa068b34b040..3cafdf22c909 100644
--- a/drivers/spmi/hisi-spmi-controller.c
+++ b/drivers/spmi/hisi-spmi-controller.c
@@ -344,6 +344,7 @@ static void __exit spmi_controller_exit(void)
  }
  module_exit(spmi_controller_exit);
  
+MODULE_DESCRIPTION("Hisilicon 3670 SPMI Controller driver");
  MODULE_LICENSE("GPL v2");
  MODULE_VERSION("1.0");
  MODULE_ALIAS("platform:spmi_controller");
diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 791cdc160c51..f240fcc5a4e1 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -1891,5 +1891,6 @@ static struct platform_driver spmi_pmic_arb_driver = {
  };
  module_platform_driver(spmi_pmic_arb_driver);
  
+MODULE_DESCRIPTION("Qualcomm MSM SPMI Controller (PMIC Arbiter) driver");
  MODULE_LICENSE("GPL v2");
  MODULE_ALIAS("platform:spmi_pmic_arb");

---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240609-md-drivers-spmi-51a13baa2301

Following up to see if anything else is needed from me. Hoping to see this in
linux-next so I can remove it from my tracking spreadsheet :)

I still don't see this in linux-next.
Adding Greg KH since seems he's been merging this driver.
My hope is to have these warnings fixed tree-wide in 6.11.

/jeff








