Hi, On 6/12/24 6:56 AM, Jeff Johnson wrote: > With ARCH=x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/intel/pmc/intel_pmc_core_pltdrv.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/intel/intel-hid.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/intel/intel-vbtn.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/intel/intel-rst.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/intel/intel-smartconnect.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > --- > drivers/platform/x86/intel/hid.c | 1 + > drivers/platform/x86/intel/pmc/pltdrv.c | 1 + > drivers/platform/x86/intel/rst.c | 1 + > drivers/platform/x86/intel/smartconnect.c | 1 + > drivers/platform/x86/intel/vbtn.c | 1 + > 5 files changed, 5 insertions(+) > > diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c > index c7a827645864..10cd65497cc1 100644 > --- a/drivers/platform/x86/intel/hid.c > +++ b/drivers/platform/x86/intel/hid.c > @@ -38,6 +38,7 @@ MODULE_PARM_DESC(enable_sw_tablet_mode, > /* When NOT in tablet mode, VGBS returns with the flag 0x40 */ > #define TABLET_MODE_FLAG BIT(6) > > +MODULE_DESCRIPTION("Intel HID Event hotkey driver"); > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Alex Hung"); > > diff --git a/drivers/platform/x86/intel/pmc/pltdrv.c b/drivers/platform/x86/intel/pmc/pltdrv.c > index ddfba38c2104..f2cb87dc2d37 100644 > --- a/drivers/platform/x86/intel/pmc/pltdrv.c > +++ b/drivers/platform/x86/intel/pmc/pltdrv.c > @@ -86,4 +86,5 @@ static void __exit pmc_core_platform_exit(void) > > module_init(pmc_core_platform_init); > module_exit(pmc_core_platform_exit); > +MODULE_DESCRIPTION("Intel PMC Core platform driver"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/platform/x86/intel/rst.c b/drivers/platform/x86/intel/rst.c > index 6bc9c4a603e0..f3a60e14d4c1 100644 > --- a/drivers/platform/x86/intel/rst.c > +++ b/drivers/platform/x86/intel/rst.c > @@ -7,6 +7,7 @@ > #include <linux/module.h> > #include <linux/slab.h> > > +MODULE_DESCRIPTION("Intel Rapid Start Technology Driver"); > MODULE_LICENSE("GPL"); > > static ssize_t irst_show_wakeup_events(struct device *dev, > diff --git a/drivers/platform/x86/intel/smartconnect.c b/drivers/platform/x86/intel/smartconnect.c > index cd25d0585324..31019a1a6d5e 100644 > --- a/drivers/platform/x86/intel/smartconnect.c > +++ b/drivers/platform/x86/intel/smartconnect.c > @@ -6,6 +6,7 @@ > #include <linux/acpi.h> > #include <linux/module.h> > > +MODULE_DESCRIPTION("Intel Smart Connect disabling driver"); > MODULE_LICENSE("GPL"); > > static int smartconnect_acpi_init(struct acpi_device *acpi) > diff --git a/drivers/platform/x86/intel/vbtn.c b/drivers/platform/x86/intel/vbtn.c > index 84c1353eb12b..9b7ce03ba085 100644 > --- a/drivers/platform/x86/intel/vbtn.c > +++ b/drivers/platform/x86/intel/vbtn.c > @@ -24,6 +24,7 @@ > > #define VGBS_TABLET_MODE_FLAGS (VGBS_TABLET_MODE_FLAG | VGBS_TABLET_MODE_FLAG_ALT) > > +MODULE_DESCRIPTION("Intel Virtual Button driver"); > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("AceLan Kao"); > > > --- > base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 > change-id: 20240611-md-drivers-platform-x86-intel-16fa0454fe2b >
