On 6/20/2024 4:41 PM, Gabriel Krisman Bertazi wrote: > >> Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes: >> >>> Currently 'make W=1' reports: >>> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/unicode/utf8data.o >>> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/unicode/utf8-selftest.o >>> >>> Add a MODULE_DESCRIPTION() to utf8-selftest.c and utf8data.c_shipped, >>> and update mkutf8data.c to add a MODULE_DESCRIPTION() to any future >>> generated utf8data file. >>> >>> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> >>> --- >>> Note that I verified that REGENERATE_UTF8DATA creates a file with >>> the correct MODULE_DESCRIPTION(), but that file has significantly >>> different contents than utf8data.c_shipped using the current: >>> https://www.unicode.org/Public/UNIDATA/UCD.zip >> >> Thanks for reporting this. I'll investigate and definitely regenerate >> the file. > > Now that I investigated it, I realized there is perhaps a > misunderstanding and not an issue. I just tried regenerating utf8data.c > and the file is byte-per-byte equal utf8data_shipped.c, so all is > good. > > Considering the link you posted, I suspect you used the latest > unicode version and not version 12.1, which we support. So there is no > surprise the files won't match. > >> The patch is good, I'll apply it to the unicode code tree >> following the fix to the above issue. > > Applied! > > ty, > yes, I was using current data. thanks for taking the patch -- two more files to color green in my spreadsheet :)
