Sun, Jun 16, 2024 at 10:01:48PM CEST, quic_jjohnson@xxxxxxxxxxx wrote: >With ARCH=hexagon, make allmodconfig && make W=1 C=1 reports: >WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/ethernet/synopsys/dwc-xlgmac.o > >With most other ARCH settings the MODULE_DESCRIPTION() is provided by >the macro invocation in dwc-xlgmac-pci.c. However, for hexagon, the >PCI bus is not enabled, and hence CONFIG_DWC_XLGMAC_PCI is not set. >As a result, dwc-xlgmac-pci.c is not compiled, and hence is not linked >into dwc-xlgmac.o. > >To avoid this issue, relocate the MODULE_DESCRIPTION() and other >related macros from dwc-xlgmac-pci.c to dwc-xlgmac-common.c, since >that file already has an existing MODULE_LICENSE() and it is >unconditionally linked into dwc-xlgmac.o. > >Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> Looks okay. Missing "Fixes" tag though. Please add it and send v2. Also, please make obvious what tree you target using "[PATCH net]" prefix. Thanks. pw-bot: cr
