On Thu, Jun 13, 2024 at 02:36:21PM -0700, Jeff Johnson wrote:
> With ARCH=arm64, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/edac/layerscape_edac_mod.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> ---
> drivers/edac/layerscape_edac.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/edac/layerscape_edac.c b/drivers/edac/layerscape_edac.c
> index d2f895033280..b70d5d258fcb 100644
> --- a/drivers/edac/layerscape_edac.c
> +++ b/drivers/edac/layerscape_edac.c
> @@ -69,6 +69,7 @@ static void __exit fsl_ddr_mc_exit(void)
>
> module_exit(fsl_ddr_mc_exit);
>
> +MODULE_DESCRIPTION("Freescale Layerscape EDAC module");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("NXP Semiconductor");
> module_param(edac_op_state, int, 0444);
>
> ---
$ git grep -E "MODULE_(DESCRIPTION|LICENSE)" drivers/edac/
I'd expect to see regular pairs like this:
drivers/edac/al_mc_edac.c:348:MODULE_LICENSE("GPL v2");
drivers/edac/al_mc_edac.c:350:MODULE_DESCRIPTION("Amazon's Annapurna Lab's Memory Controller EDAC Driver");
drivers/edac/altera_edac.c:2216:MODULE_DESCRIPTION("EDAC Driver for Altera Memories");
drivers/edac/amd64_edac.c:4238:MODULE_LICENSE("GPL");
drivers/edac/amd64_edac.c:4240:MODULE_DESCRIPTION("MC support for AMD64 memory controllers");
...
but there are cases which need fixing.
How about you do them all with one patch?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
