Re: [PATCH] fs/proc/task_mmu: fix uninitialized variable in pagemap_pmd_range()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13.06.24 16:34, Dan Carpenter wrote:
The "folio" pointer is tested for NULL, but it's either valid or
uninitialized.  Initialize it to NULL.

Fixes: 84f57f8b8914 ("fs/proc: move page_mapcount() to fs/proc/internal.h")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
  fs/proc/task_mmu.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 631371cb80a0..6ed1f56b32b4 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -1492,7 +1492,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end,
  		u64 flags = 0, frame = 0;
  		pmd_t pmd = *pmdp;
  		struct page *page = NULL;
-		struct folio *folio;
+		struct folio *folio = NULL;
if (vma->vm_flags & VM_SOFTDIRTY)
  			flags |= PM_SOFT_DIRTY;

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

Thanks!

--
Cheers,

David / dhildenb





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux