On Sun, 26 May 2024, Christophe JAILLET wrote: > joycon_leds_create() has a ida_alloc() call. So if an error occurs after > it, a corresponding ida_free() call is needed, as already done in the > .remove function. > > This is not 100% perfect, because if ida_alloc() fails, then > 'ctlr->player_id' will forced to be U32_MAX, and an error will be logged > when ida_free() is called. > > Considering that this can't happen in real life, no special handling is > done to handle it. > > Fixes: 5307de63d71d ("HID: nintendo: use ida for LED player id") > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> Applied, thanks. -- Jiri Kosina SUSE Labs