On Fri, May 31, 2024 at 02:06:48PM -0700, Kees Cook wrote:
> ...
> or refactors and forgets to change some name, etc. It's all for catching
> bugs before they happen, etc. And when source string lengths aren't
> known, the runtime checking can kick in too.
Aha, thanks for explaining.
> It happens x86 boot doesn't have any of those (good!) so
> __fortify_panic() goes unused there. But
Exactly!
> that's a larger topic covered by stuff like
> CONFIG_LD_DEAD_CODE_DATA_ELIMINATION, etc.
"... This option is not well tested yet, so use at your own risk."
Oh well.
So I get an allergic reaction everytime we wag the dog - i.e., fix the
code because some tool or option can't handle it even if it is
a perfectly fine code. In that case it is an unused symbol.
And frankly, I'd prefer the silly warning to denote that fortify doesn't
need to do any checking there vs shutting it up just because.
So can we aim our efforts at real bugs please?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
