On Sat, May 25, 2024 at 05:14:35PM +0200, Christophe JAILLET wrote: > The only iommu function call in this driver is a > tegra_dev_iommu_get_stream_id() which does not allocate anything and does > not take any reference. > > More-over, what is freed is "se->dev" which has been devm_kzalloc()'ed in > the probe. > > So there is no point in calling iommu_fwspec_free() in the remove function. > > Remove this incorrect function call. > > Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver") > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > --- > Compile tested only > > This patch is completely speculative. *Review with care*. > --- > drivers/crypto/tegra/tegra-se-main.c | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt