> The only iommu function call in this driver is a > tegra_dev_iommu_get_stream_id() which does not allocate anything and does > not take any reference. > > More-over, what is freed is "se->dev" which has been devm_kzalloc()'ed in the > probe. I did not completely understand what is being tried to convey here. If I understand it right, iommu_fwspec_free() does not do anything with the "devm_kzalloc"ed variable. It would probably be a good idea to remove this line from the commit message. > > So there is no point in calling iommu_fwspec_free() in the remove function. > > Remove this incorrect function call. > > Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver") > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>