On Sun, May 26, 2024 at 06:49:11PM +0200, Julia Lawall wrote: > I'm not the one to decide whether we should use cleanup for mutex locks. > Intuitively, my opinion would be that we should not. Something that can > have so much impact on the execution of the system should be visible. But > that's just my opinion. Different subsystems are taking different approaches to the cleanup.h code. Sound adopted it. Networking is taking it slow. Some GPIO cleanup.h code was merged and some wasn't. It really does change how you review code, so mass conversion patches probably aren't welcome. regards, dan carpenter