> Furthermore, require error checking for callers of amd_smn_read() and > amd_smn_write(). This is needed because many error conditions cannot > be checked by these functions. Does such information qualify for the tag “Fixes”? > … And remove a warning > that will not be trigger in many cases. triggered? I suggest to perform this source code cleanup in a separate update step. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n81 Regards, Markus