On Tue, 21 May 2024, Markus Elfring wrote: > >>>> … > >>>>> Fix this by reordering the kfree() post the dereference. > … > > The original wording of the commit message really is fine as is, > > I see no need for Harshit to send a new version and I plan to > > merge this as is. > > Are there opportunities remaining to improve the discussed wording? > > 1. https://en.wiktionary.org/wiki/post#Etymology_1 > > 2. https://en.wiktionary.org/wiki/reorder > > 3. Function call indication? > https://elixir.bootlin.com/linux/v6.9.1/source/mm/slub.c#L4371 > > 4. Rephrasing of “Fix this by …”? > > 5. https://en.wikipedia.org/wiki/Dangling_pointer#Cause_of_dangling_pointers > > 6. https://wiki.sei.cmu.edu/confluence/display/c/MEM30-C.+Do+not+access+freed+memory#MEM30C.Donotaccessfreedmemory-AutomatedDetection > > 7. https://en.wikipedia.org/wiki/Code_sanitizer#KernelAddressSanitizer We'll not waste our time in wordsmithing commit messages to perfection, the current one is good enough as was stated to you already. -- i.
