Re: [PATCH] eventfs: Directly return NULL to avoid null point dereferenced

[Hao Ge <hao.ge@xxxxxxxxx>]

Hi Markus


Thanks for your review.


在 5/13/24 01:12, Markus Elfring 写道:
> > When the condition ei->is_free holds,we return NULL directly to
> > avoid update_events_attr to use NULL point about ei.
> * Please avoid typos in the summary phrase and the commit message.
>
> * Would you like to use an imperative wording for an improved change description?
>    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc7#n94
>
>
> …
OK, I'll study it,
> > +++ b/fs/tracefs/event_inode.c
> > @@ -346,8 +346,7 @@ static struct eventfs_inode *eventfs_find_events(struct dentry *dentry)
> >   		 * doesn't matter.
> >   		 */
> >   		if (ei->is_freed) {
> > -			ei = NULL;
> > -			break;
> > +			return NULL;
> >   		}
> …
>
> How do you think about to omit curly brackets here?
You are right, I will make changes to it in future versions
> Regards,
> Markus

Best Regards

Hao