On Sat, May 11, 2024 at 03:23:04PM +0100, Simon Horman wrote:
> On Thu, May 09, 2024 at 02:00:18PM +0300, Dan Carpenter wrote:
> > If mlx5_query_hca_caps_light() fails then calling devl_unregister() or
> > devl_unlock() is a bug. It's not registered and it's not locked. That
> > will trigger a stack trace in this case because devl_unregister() checks
> > both those things at the start of the function.
> >
> > If mlx5_devlink_params_register() fails then this code will call
> > devl_unregister() and devl_unlock() twice which will again lead to a
> > stack trace or possibly something worse as well.
> >
> > Fixes: bf729988303a ("net/mlx5: Restore mistakenly dropped parts in register devlink flow")
> > Fixes: c6e77aa9dd82 ("net/mlx5: Register devlink first under devlink lock")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Hi Dan,
>
> I believe that after you posted this patch, a different fix for this was
> added to net as:
>
> 3c453e8cc672 ("net/mlx5: Fix peer devlink set for SF representor devlink port")
>
Ah good. Plus that patch has been tested.
regards,
dan carpenter
