Re: [PATCH net-next 5/5] gve: Add flow steering ethtool support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



…
> +++ b/drivers/net/ethernet/google/gve/gve_ethtool.c
…
> +static int gve_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd, u32 *rule_locs)
> +{
> +	struct gve_priv *priv = netdev_priv(netdev);
> +	int err = 0;
> +
> +	dev_hold(netdev);
> +	rtnl_unlock();
…
> +out:
> +	rtnl_lock();
> +	dev_put(netdev);
> +	return err;
> +}
…

How do you think about to increase the application of scope-based resource management
at such source code places?

Regards,
Markus





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux