Re: [PATCH] iio: tmag5273: Remove some unused field in struct tmag5273_data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christophe,

Am 01.05.2024 um 13:28 schrieb Christophe JAILLET:
> In "struct tmag5273_data", the 'scale' and 'vcc' fields are unused.
> Remove them.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> Compile tested only.
> 
> It was added in the initial commit 866a1389174b ("iio: magnetometer: add
> ti tmag5273 driver") but was never used.
> ---
>  drivers/iio/magnetometer/tmag5273.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/tmag5273.c b/drivers/iio/magnetometer/tmag5273.c
> index 218b1ce076c1..4187abe12784 100644
> --- a/drivers/iio/magnetometer/tmag5273.c
> +++ b/drivers/iio/magnetometer/tmag5273.c
> @@ -118,11 +118,9 @@ struct tmag5273_data {
>  	unsigned int version;
>  	char name[16];
>  	unsigned int conv_avg;
> -	unsigned int scale;
>  	enum tmag5273_scale_index scale_index;
>  	unsigned int angle_measurement;
>  	struct regmap *map;
> -	struct regulator *vcc;
>  
>  	/*
>  	 * Locks the sensor for exclusive use during a measurement (which

Thanks for cleaning up.

Reviewed-by: Gerald Loacker <gerald.loacker@xxxxxxxxxxxxxx>

Regards,
Gerald




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux