On Wed, 24 Apr 2024 14:40:11 +0300
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
Hi Dan,
thanks for having a look!
> The dt_has_supported_hw() function returns type bool. That means these
> negative error codes are cast to true but the function should return
> false instead.
Ouch, of course! I refactored the function during development, but missed
that part.
> Fixes: fa5aec9561cf ("cpufreq: sun50i: Add support for opp_supported_hw")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>
Thanks,
Andre
> ---
> drivers/cpufreq/sun50i-cpufreq-nvmem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> index cd50cea16a87..0b882765cd66 100644
> --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> @@ -136,11 +136,11 @@ static bool dt_has_supported_hw(void)
>
> cpu_dev = get_cpu_device(0);
> if (!cpu_dev)
> - return -ENODEV;
> + return false;
>
> np = dev_pm_opp_of_get_opp_desc_node(cpu_dev);
> if (!np)
> - return -ENOENT;
> + return false;
>
> for_each_child_of_node(np, opp) {
> if (of_find_property(opp, "opp-supported-hw", NULL)) {
