There are two bugs in this code:
1) The "irq" variable needs to be signed for the error handling to
work.
2) The of_irq_get_byname() also returns zero on error so change the
comparison from < 0 to <= 0.
Fixes: 932282f154ac ("spmi: pmic-arb: Register controller for bus instead of arbiter")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
drivers/spmi/spmi-pmic-arb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 0a17ff02c827..791cdc160c51 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -1672,7 +1672,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
void __iomem *intr;
void __iomem *cnfg;
int index, ret;
- u32 irq;
+ int irq;
ctrl = devm_spmi_controller_alloc(dev, sizeof(*bus));
if (IS_ERR(ctrl))
@@ -1721,8 +1721,8 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
return PTR_ERR(intr);
irq = of_irq_get_byname(node, "periph_irq");
- if (irq < 0)
- return irq;
+ if (irq <= 0)
+ return irq ?: -ENXIO;
bus->pmic_arb = pmic_arb;
bus->intr = intr;
--
2.43.0
