Re: [PATCH][next] ocfs2: remove redundant assignment to variable status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/24/24 06:30, Colin Ian King wrote:
Variable status is being assigned and error code that is never read, it is
being assigned inside of a do-while loop. The assignment is redundant and
can be removed.

Cleans up clang scan build warning:
fs/ocfs2/dlm/dlmdomain.c:1530:2: warning: Value stored to 'status' is never
read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
---
  fs/ocfs2/dlm/dlmdomain.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs/ocfs2/dlm/dlmdomain.c
index 2e0a2f338282..2018501b2249 100644
--- a/fs/ocfs2/dlm/dlmdomain.c
+++ b/fs/ocfs2/dlm/dlmdomain.c
@@ -1527,7 +1527,6 @@ static void dlm_send_join_asserts(struct dlm_ctxt *dlm,
  {
  	int status, node, live;
- status = 0;
  	node = -1;
  	while ((node = find_next_bit(node_map, O2NM_MAX_NODES,
  				     node + 1)) < O2NM_MAX_NODES) {

This mail cc linux-kernel@xxxxxxxxxxxxxxx, it would be better to only
cc ocfs2-devel next time.

This patch is correct, but it's a very trivial fix. I am not sure if
Joseph is willing to take time to push to mainline kernel.

Thanks,
Heming




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux