On Tue, Apr 23, 2024 at 09:55:57AM -0500, Nick Child wrote:
> > You're right that it doesn't affect the behavior of the driver except
> > for the debug output when we do:
> >
> > netdev_dbg(adapter->netdev, "Reset failed, rc=%d\n", rc);
> >
> > But the - was left off uninitentionally so I think we should apply it.
> >
> > I have been trying to look for similar bugs where the - is left off.
> > It's a bit challenging because there places where we use positive
> > error codes deliberately. But in this case a static checker could
> > easily detect the bug with a low false positive ratio by saying, "We're
> > mixing normal negative error codes with positive EBUSY".
> >
> > regards,
> > dan carpenter
>
> Hello, small clarification, this patch will not effect the debug print
> statement due to the break statement immediately following:
> while () {
> if () {
> rc = -EBUSY;
> break;
> }
> netdev_dbg(adapter->netdev, "Reset failed, rc=%d\n", rc);
> }
> Though this return code can be passed to adapter->reset_done_rc, which is
> only treated as a boolean.
>
> So, the point of the patch not doing any behavioral differences is still
> true.
Ah yes. You're right.
regards,
dan carpenter
