On 15/04/2024 22.47, Christophe JAILLET wrote: > Le 04/01/2024 à 14:29, Christophe JAILLET a écrit : >> Most of seq_puts() usages are done with a string literal. In such cases, >> the length of the string car be computed at compile time in order to save >> a strlen() call at run-time. seq_write() can then be used instead. >> >> This saves a few cycles. >> >> To have an estimation of how often this optimization triggers: >> $ git grep seq_puts.*\" | wc -l >> 3391 >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > > Hi, > > any feed-back on this small optimisation of seq_puts()? While you're at it, could you change the implementation of the out-of-line seq_puts (or __seq_puts if it gets renamed to that) to simply be seq_write(seq, s, strlen(s)) instead of duplicating the overflow/memcpy logic. Rasmus
