Re: [PATCH v2] ftrace: Fix possible use-after-free issue in ftrace_location()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Zheng Yejian <zhengyejian1@xxxxxxxxxx>, linux-trace-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, Mark Rutland <mark.rutland@xxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>
Subject: Re: [PATCH v2] ftrace: Fix possible use-after-free issue in ftrace_location()
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Tue, 16 Apr 2024 17:57:33 +0200
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20240416112459.1444612-1-zhengyejian1@huawei.com>
References: <20240416112459.1444612-1-zhengyejian1@huawei.com>
Ui-outboundreport: notjunk:1;M01:P0:1fbYECY+dng=;+1DYhBjlCdbR2Vf5//lqiN4Yw3R gNcEV/8sH0uXm44607oje8/jq9JLdXYw4Xe95o1zObM+k+7+0qaztqAGjgIychDdbU3x22SVo irESF06Lp4g/5+5RNK79CExkXtcXgZcUezK/62FDoRmI6d2W0J9QQRXKYta7wYbiqWZ3oSlYl FAzozpHm5bOnkhUGgZ1Un2yBujACqHbvhXSqY5UOLyF3oszp8PGdxj+F6+bx1Vr7jPzcdeNyi npHhH2KIHpfwCujIDx+uLJdAvPWLleA35IhjlydlWNBzl4UtY39BBT63gTUfV49Ir+9AgY9j9 9UgG+hI3AjoBGjc3keSsS7a8xhmxT2ZJ3yut5gI6Rr1TzeSqm/n1Sk4/weli/ujGgMokrd1kc XscO/DNqhvXHSKRyQdcwjdA0Ww/DYPZE4k9hba/0H6uPf+1VMF41XZugCHLMFq1Q4moxoDcAl HGGY+KAdh73GUDeadhB9smvRhMBpg8S5yXCEXnzu+QFMh+BJEcWQL+TFpWVL3Moz2b9pFYP+n KaMBJYrRmHcOcBW6+GT1slz0ze0vr6ThTvykO6y/welS9yT2kM2T2H3tQKGhC3qW3r28xweYl 2VQAJi/deb+TRNcURXJJ7vVbywo/tDW53wI4wN+3C90/eV9mr3GhceMNU4NY/FsnnX+ucXlqk ADGb+GVVmq5KAvcSfMzAcTgMsT6KHoBxQmlPwxYc6l3tJH6D6AXuI0Yc0EH927vWLIqFO/ubb B2ug/kiuhb3HjPxAYMyVs9WMjHk+fJ0rs9qxo0UNdeUx1/5h2WHuwLN5toOGr2GmJLuygsTr9 G0f+3yWUUE0x99PN+ETGwDaTfYddLkaVplER19FeRlQQs=
User-agent: Mozilla Thunderbird

…
> To fix it, we hold rcu lock as lookuping ftrace record, and call
> synchronize_rcu() before freeing any ftrace pages.

I suggest to convert this description into an imperative wording.

Regards,
Markus

Prev by Date: Re: [0/2] powerpc/powernv/vas: Adjustments for map_paste_region()?
Next by Date: RE: [PATCH] seq_file: Optimize seq_puts()
Previous by thread: Re: [PATCH 03/35] media: uvcvideo: Refactor iterators
Next by thread: [PATCH wireless] wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]