On 11/04/2024 11:31, Dan Carpenter wrote:
On Thu, Apr 11, 2024 at 10:04:10AM +0000, Tung Quang Nguyen wrote:I suggest that err variable should be completely removed. Could you please also do the same thing for this code ? " ... err = skb_handler(skb, cb, tsk); if (err) {If we write the code as: if (some_function(parameters)) { then at first that looks like a boolean. People probably think the function returns true/false. But if we leave it as-is: err = some_function(parameters); if (err) { Then that looks like error handling. So it's better and more readable to leave it as-is. regards, dan carpenter
I concur with Dan's comments. Colin
