Re: [PATCH v3 6/7] staging: pi433: Add debugfs_remove in case of driver register fails.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Shahar Avidar <ikobh7@xxxxxxxxx>, linux-staging@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, "Felix N. Kimbu" <felixkimbu1@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Hans Verkuil <hverkuil-cisco@xxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>
Subject: Re: [PATCH v3 6/7] staging: pi433: Add debugfs_remove in case of driver register fails.
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Fri, 5 Apr 2024 12:42:38 +0200
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Dan Carpenter <dan.carpenter@xxxxxxxxxx>
In-reply-to: <20240405074000.3481217-7-ikobh7@gmail.com>
References: <20240405074000.3481217-7-ikobh7@gmail.com>
Ui-outboundreport: notjunk:1;M01:P0:sHoSA0adK7U=;BmEev2IrjKj4JG7kD3JEGVdUydM v7PvTR4wFJlwfSIwjIVZLAGnTd5SXewMjTxXRTFvpwMQJDIHygFahK8quWhIc7l8LImIBKxq3 J2VyPDOXsStOGLcPfIRJN5tZjlVEbxBzUKBHGDpy06Is5fUrkvrheoWXET5U8XR8VY1oZj4Jh 55TfsGXcuJGq5NzxmkHQ8E2495Z1/CuMPASm9Ff078ZqO2rKyKQIL6CvJdjNwzH8U9OSxOo+A xYCGHu5U/morsY1gqVsaCjCaoftyddEfr2M3/LX5fvS6ooDgXjIZisnqBuEQ02aZDmhdHti4X 2PfjkuohfRK9ch4D8DtkthAPhXnO4MDeU88f4oPMsAkX+EID0w8XaJEyYk4aOboku8dRnjltI wFQXYEyLqH4ZXpOeME29aSJbbrZHvzSvDfp0VBOleXqoJLB+3EqFlpVbLuT6MtugTF6YSZD+W IxCxRf402jWu6fbuAETipbbKXugrtxgx5Re3jAQL4OccLXLg0QRrGUpI2BpbOVd8fUjuyVPkb p43VkE5f31ThKxgDQM1bQJV74c184SHCsAVnxGMABvt+gs6+zItM9Jh4dgUo2pMFPDV02L80P S8AyboP7uxCbeiwyKqyACTIOVDv35T9QY066xjEWBIp/PWGcNjmi3E71nF/xmxOE2vPfAaDy1 9k6xGnMWc8vLZg5JuElv7sle5jz4DrXQaX6IbNMSmdj23X6qhsQYWdLx89qT+fGiFOVAG9WnO RRywZ7yRpRlsijuedh3zzIE5L9pc7rQDrKaV5szNV0ZnaHFMaDTp4EPkyFsmMrgTDzXkXVq0m i6KygoM1yRuFsS7sWKbL+LMAqtjNlu3Ll8fXvqDk/tgM8=
User-agent: Mozilla Thunderbird

I suggest to use the summary phrase “Call debugfs_remove() in case of
driver registration failure in pi433_init()” instead.


> debugfs resources were never cleaned in case of failure to register driver.

How do you think about to use a change description like the following?

   Debugfs resources were not released after a call of
   the function “spi_register_driver” failed.
   Thus fix the exception handling accordingly.


Regards,
Markus

Follow-Ups:
- Re: [PATCH v3 6/7] staging: pi433: Add debugfs_remove in case of driver register fails.
  - From: Greg Kroah-Hartman

Prev by Date: Re: [PATCH v3 5/7] staging: pi433: Remove duplicated code using the "goto" error recovery scheme.
Next by Date: Re: [PATCH v3 6/7] staging: pi433: Add debugfs_remove in case of driver register fails.
Previous by thread: [bug report] soc: xilinx: Fix for call trace due to the usage of smp_processor_id()
Next by thread: Re: [PATCH v3 6/7] staging: pi433: Add debugfs_remove in case of driver register fails.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]