Re: [PATCH] Subject: Improved help text for rtl8712

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ayaan,

This patch obviously got a bit mangled in transmission as you can see.
Read the first paragraph of Documentation/process/email-clients.rst, but
then do a google search on how to use git send-email.  Send patches to
yourself until you figure it out.

After that use scripts/get_maintainer.pl to create the correct CC list.

On Wed, Mar 06, 2024 at 08:15:35PM +0530, Ayaan Mirza Baig wrote:
> 
> >From df9050d0dff9e4160172dbc910f718c16095fc8d Mon Sep 17 00:00:00 2001
> From: Ayaan Mirza Baig <ayaanmirza.788@xxxxxxxxx>
> Date: Wed, 6 Mar 2024 19:53:12 +0530
> 
> Rewrote the help text paragraph for R8712U and R8712_TX_AGGR
> 

The commit message needs to say what wrong with the original help text
and why you are re-writing it.

I suspect that you're re-writing it just to make it longer than the 4 (?)
line minimum.  Don't bother with that.  Checkpatch is overly strict.
People can understand the help text fine even though it's just 3 lines.

regards,
dan carpenter





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux