On Mon, 26 Feb 2024 at 22:37, Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:
>
> This looks strange to call release_mem_region() in a remove function
> without any request_mem_region() in the probe or "struct resource"
> somewhere.
>
> So remove the corresponding code.
>
> Fixes: 3a96dff0f828 ("mmc: SD/MMC Host Controller for Wondermedia WM8505/WM8650")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Applied for next, thanks!
> ---
> This patch is speculative. Review with care.
> Compile tested only.
It looks to me that $subject patch doesn't make things any worse.
Potentially we may want to call request|release_resource() (or
similar) during probe/remove, but as that isn't done during probe
today, I decided to pick this up as is.
Kind regards
Uffe
> ---
> drivers/mmc/host/wmt-sdmmc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
> index 77d5f1d24489..860380931b6c 100644
> --- a/drivers/mmc/host/wmt-sdmmc.c
> +++ b/drivers/mmc/host/wmt-sdmmc.c
> @@ -883,7 +883,6 @@ static void wmt_mci_remove(struct platform_device *pdev)
> {
> struct mmc_host *mmc;
> struct wmt_mci_priv *priv;
> - struct resource *res;
> u32 reg_tmp;
>
> mmc = platform_get_drvdata(pdev);
> @@ -911,9 +910,6 @@ static void wmt_mci_remove(struct platform_device *pdev)
> clk_disable_unprepare(priv->clk_sdmmc);
> clk_put(priv->clk_sdmmc);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - release_mem_region(res->start, resource_size(res));
> -
> mmc_free_host(mmc);
>
> dev_info(&pdev->dev, "WMT MCI device removed\n");
> --
> 2.43.2
>
