On 3/1/24 15:04, Michael Walle wrote:
> Hi,
>
> On Fri Mar 1, 2024 at 3:45 PM CET, Muhammad Usama Anjum wrote:
>> The i should be signed to find out the end of the loop. Otherwise,
>> i >= 0 is always true and loop becomes infinite.
>>
>> Fixes: 6a9eda34418f ("mtd: spi-nor: core: set mtd->eraseregions for non-uniform erase map")
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
>> ---
>> drivers/mtd/spi-nor/core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
>> index 65b32ea59afc6..46bc45b80883f 100644
>> --- a/drivers/mtd/spi-nor/core.c
>> +++ b/drivers/mtd/spi-nor/core.c
>> @@ -3373,7 +3373,7 @@ static u32
>> spi_nor_get_region_erasesize(const struct spi_nor_erase_region *region,
>> const struct spi_nor_erase_type *erase_type)
>> {
>> - u8 i;
>> + s8 i;
>
> Can we just have an "int" here. So we don't shoot ourselves in the
Muhammad, do you care to resubmit using int? Would be better indeed.
> foot again. I'm really no friend of these kind of micro
> optimizations, it should have been int in the first place IMHO.
>
> -michael
>
>>
>> if (region->overlaid)
>> return region->size;
>
